feature flag root table sorting functionality issue fixed #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yagnik56
requested review from
VivekFitkariwala,
bcb37,
ppratikcr7 and
zackcl
|
I tried this PR, but the sorting works differently from the Experiments root page. On the Experiments root page, it sorts the lists regardless of their capitalization, which I believe is the expected behavior. 
However, on the Feature Flags root page, it sorts the lists by flags starting with uppercase and lowercase separately. 
I believe this should work the same way as the Experiments root page. My research of some other apps shows they also sort lists regardless of capitalization. |
zackcl
approved these changes
Sep 18, 2024
VivekFitkariwala
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the sorting issue in the feature flag root table.